Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In NullArgumentForNonNullParameter, don't trigger completion for NullMarked. #4462

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

In NullArgumentForNonNullParameter, don't trigger completion for NullMarked.

Completion can fail under --release 8, leading to warning: unknown enum constant ElementType.MODULE.

This CL is one of a variety of ways that I'll be addressing google/truth#1320. It alone should be sufficient (unless there are other problems that I'm unaware of), but I'll do more, both for people who might not upgrade Error Prone immediately and for anyone else (NullAway?) who writes a check that calls hasAnnotation(nullMarked).

…ullMarked`.

Completion can fail under `--release 8`, leading to `warning: unknown enum constant ElementType.MODULE`.

This CL is one of a variety of ways that I'll be addressing google/truth#1320. It alone should be sufficient (unless there are other problems that I'm unaware of), but I'll do more, both for people who might not upgrade Error Prone immediately and for anyone else (NullAway?) who writes a check that calls `hasAnnotation(nullMarked)`.

PiperOrigin-RevId: 651801963
@copybara-service copybara-service bot merged commit 77e4f72 into master Jul 12, 2024
@copybara-service copybara-service bot deleted the test_651770651 branch July 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant